Element Tracking Plugin Schemas #1421
Draft
+337
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethron
force-pushed
the
feature/element-tracking-plugin
branch
from
14df289 to
fd9f4dc
Compare
| "minimum": 0.0, | ||
| "maximum": 1.0 | ||
| }, | ||
| "max_y_depth_percentage": { |
There was a problem hiding this comment.
Nit: the _percentage suffix is a bit confusing given that the range is from 0 to 1 (would expect 0 to 100). Maybe call it ratio or change the scale?
| }, | ||
| "total_time_visible_ms": { | ||
| "description": "The cumulative amount of time (in milliseconds) this element has been in view so far.", | ||
| "type": "number", |
There was a problem hiding this comment.
Probably we can go for integer given this is in ms already?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds schemas for a new proposed Element Tracking plugin for the JavaScript Tracker.
It contains 4 Self Describing Events:
create_elementdestroy_elementexpose_elementobscure_elementAnd 4 entities:
elementelement_contentelement_statisticscomponent_parentsThis is a draft PR to allow review of the actual plugin.